fix(CDC_OPTIONS): Use boolean value for cdc preimage option

[aleksbykov]

CDC_SETTINGS_NAMES_VALUES['preimage'] uses string values "true" "false" instead of bool True False. This cause assertion error if it was changed

AssertionError: CDC extension settings are differs.
Current: {'delta': 'full', 'enabled': True, 'preimage': True, 'postimage': True, 'ttl': '1800'}
expected: {'delta': 'full', 'enabled': True, 'preimage': 'true', 'postimage': True, 'ttl': '1800'}

Testing

• [ ]

PR pre-checks (self review)

• [ ] I added the relevant backport labels
• [ ] I didn't leave commented-out/debugging code

Reminders

• Add New configuration option and document them (in sdcm/sct_config.py)
• Add unit tests to cover my changes (under unit-test/ folder)
• Update the Readme/doc folder relevent to this change (if needed)

[soyacz]

@aleksbykov please mark it as 'ready for review' if you verified it (even locally, e.g. with docker backend). This issue is failing tests.

[aleksbykov]

@aleksbykov please mark it as 'ready for review' if you verified it (even locally, e.g. with docker backend). This issue is failing tests.

@soyacz , job is passed: https://jenkins.scylladb.com/view/staging/job/scylla-staging/job/abykov/job/longevity-cdc-100gb-4h-test/12/

[aleksbykov]

@soyacz can you review and merge?

[dimakr]

@aleksbykov The issue reproduced in 2024.1.9 - https://argus.scylladb.com/test/c64d7261-b3df-451a-9d66-b8d6acb4cb35/runs?additionalRuns[]=227e1a0d-6187-46d7-9569-02e21b769fad. This fix was not backported - was it done intentionally maybe? Or we can follow up on it now?

[fruch]

@aleksbykov The issue reproduced in 2024.1.9 - https://argus.scylladb.com/test/c64d7261-b3df-451a-9d66-b8d6acb4cb35/runs?additionalRuns[]=227e1a0d-6187-46d7-9569-02e21b769fad. This fix was not backported - was it done intentionally maybe? Or we can follow up on it now?

we can follow it now