scylla-cluster-tests icon indicating copy to clipboard operation
scylla-cluster-tests copied to clipboard

fix(sct_config): send argus resolved scylla_versions

Open fruch opened this issue 1 year ago • 5 comments

in order that argus would be able to know what is the target version for a run, as soon as the test start (including the target versions for upgrade), so we can filter better even in the case of error to provision/configure scylla, or failure to start the upgrades.

Testing

  • [ ]

PR pre-checks (self review)

  • [ ] I added the relevant backport labels
  • [ ] I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevent to this change (if needed)

fruch avatar Feb 14 '24 16:02 fruch

@k0machi, here's the packages names we'll align on, on both sides:

on regular test: scylla-server-requested - version reported when reading configuration scylla-server - version reported after node installed/boot

on rolling upgrade: scylla-server-requested - target version for upgrade reported when reading configuration scylla-server-base - base version identified during reading configuration scylla-server - version reported after node installed/boot scylla-server-upgraded - version reported after node upgrade

plug we'll remove all the calls to argus_client().update_scylla_version(), right ?

fruch avatar Feb 15 '24 15:02 fruch

plug we'll remove all the calls to argus_client().update_scylla_version(), right ?

Once we have logic on argus side to update that, yes, we can remove them.

k0machi avatar Feb 15 '24 15:02 k0machi

@k0machi care to take over this one ?

fruch avatar Mar 06 '24 10:03 fruch

@k0machi care to take over this one ?

I'll take a look

k0machi avatar Mar 06 '24 11:03 k0machi

@fruch it's ready now, only thing left is to prevent duplicate submissions on argus side.

k0machi avatar May 02 '24 14:05 k0machi

@mergify backport 2024.1

fruch avatar Jun 05 '24 12:06 fruch

backport 2024.1

❌ No backport have been created

  • Backport to branch 2024.1 failed

GitHub error: Branch not found

mergify[bot] avatar Jun 05 '24 12:06 mergify[bot]

@mergify backport branch-2024.1 branch-2023.1 branch-5.4

fruch avatar Jun 05 '24 12:06 fruch

backport branch-2024.1 branch-2023.1 branch-5.4

✅ Backports have been created

mergify[bot] avatar Jun 05 '24 12:06 mergify[bot]