scylla-cluster-tests icon indicating copy to clipboard operation
scylla-cluster-tests copied to clipboard

Published 20 hours ago • verified publisher icon scylladb

Gce provision rework

Open KnifeyMoloko opened this issue 3 years ago • 4 comments

This PR refactors our GCE provisioning flow, with an aim to unify the provisioning process for all cloud backends SCT supports. Azure provisioning was taken as the prototype and this refactor maps GCE API calls and helpers we used onto the provisioning infrastructure. Additionally wherever possible, hardcoded defaults were moved to separate classes.

Trello task: https://trello.com/c/aiwxkQHZ

PR pre-checks (self review)

  • [ ] I followed KISS principle and best practices
  • [ ] I didn't leave commented-out/debugging code
  • [ ] I added the relevant backport labels
  • [ ] New configuration option are added and documented (in sdcm/sct_config.py)
  • [ ] I have added tests to cover my changes (Infrastructure only - under unit-test/ folder)
  • [ ] All new and existing unit tests passed (CI)
  • [ ] I have updated the Readme/doc folder accordingly (if needed)

KnifeyMoloko avatar May 24 '22 19:05 KnifeyMoloko

This PR is stale because it has been open 365 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Aug 02 '23 00:08 github-actions[bot]

@roydahan @soyacz @fruch , a lot of effort went into this PR... and it is not done... in one hand, to resolve the conflicts, and finish it, may take quite some time, but in other hand, it may take less time than redoing the whole thing from scratch.. what do you suggest we do here?

fgelcer avatar Aug 02 '23 05:08 fgelcer

@roydahan @soyacz @fruch , a lot of effort went into this PR... and it is not done... in one hand, to resolve the conflicts, and finish it, may take quite some time, but in other hand, it may take less time than redoing the whole thing from scratch.. what do you suggest we do here?

I would keep it as a reference for those who are gonna do a implement. (It can be a reference also closed.

Beside aligning the backends which is nice to have, I don't see this one becoming a priority soon...

fruch avatar Aug 02 '23 06:08 fruch

I agree. Do we have somewhere the relevant QA-task?

roydahan avatar Aug 08 '23 11:08 roydahan

@soyacz

you think this one is still a good basis for the work needed ? or we'll need to redo it from scratch ?

fruch avatar Jun 26 '25 22:06 fruch

@soyacz

you think this one is still a good basis for the work needed ? or we'll need to redo it from scratch ?

I think this one can be a good basis.

soyacz avatar Jun 27 '25 13:06 soyacz

I agree. Do we have somewhere the relevant QA-task?

https://github.com/scylladb/qa-tasks/issues/414

fruch avatar Jul 21 '25 15:07 fruch