scylla-cluster-tests icon indicating copy to clipboard operation
scylla-cluster-tests copied to clipboard

Published 20 hours ago • verified publisher icon scylladb

improvement(longevityPipeline): Remove default availability_zone setting

Open pehala opened this issue 9 months ago • 3 comments

There is no need to set default in Jenkins, test configuration files configure availability_zone as well and given that it is directly tied to the db_nodes setting, it makes sense to configure it only in configuration file and not have jenkins override the default in UI.

Testing

  • [ ] Test on Jenkins with various pipelines

PR pre-checks (self review)

  • [x] I added the relevant backport labels
  • [x] I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevant to this change (if needed)

pehala avatar Mar 04 '25 15:03 pehala

It does come handy in cases where you have resource issues, or when using spots.

For cases no using multiple availability zone, it's actually helpful to have this setting in the pipeline.

Regardless it's now can still be override by environment variables, so people will need to get used to using that when needed

fruch avatar Mar 04 '25 18:03 fruch

Regardless it's now can still be override by environment variables, so people will need to get used to using that when needed

The option stays, you can still override it in Jenkins, it just wont be set to any default value there

pehala avatar Mar 04 '25 18:03 pehala

What about other pipelines? We have more than just "longevity"

I will take a look at others, once I finish testing this change for longevitiy ones

pehala avatar Mar 05 '25 13:03 pehala

@juliayakovlev this is kind of connected to what you are working on for GCE, i.e. address part of the problem. can you takeover this one ? and test it ?

fruch avatar Nov 11 '25 22:11 fruch

@juliayakovlev this is kind of connected to what you are working on for GCE, i.e. address part of the problem. can you takeover this one ? and test it ?

I already opened similar draft PR https://github.com/scylladb/scylla-cluster-tests/pull/12456 and ran the different test-provision. But they are failed. I did not check why they failed. Let's add here the labels and see if it'll pass

juliayakovlev avatar Nov 12 '25 07:11 juliayakovlev

I ran test-provision-gce and test-provision-aws on the https://github.com/scylladb/scylla-cluster-tests/pull/12456 and it passed

juliayakovlev avatar Nov 13 '25 12:11 juliayakovlev