When adding a new node of a different type, the logs still write the instance type of the original cluster

[cezarmoise]

In the logs below I had started with a cluster of 3 x i4i.large then added an i4i.xlarge. The logs for the newly added logs say i4i.large.

20:48:22  < t:2025-02-19 18:48:22,357 f:cluster.py      l:4556 c:sdcm.cluster         p:INFO  > Cluster elasticity-test-grow-l-8-db-cluster-44943038 (AMI: ['ami-0730f2ca76fe9bd91'] Type: i4i.large): Clear _nemesis_termination_event
20:48:22  < t:2025-02-19 18:48:22,622 f:nemesis.py      l:468  c:sdcm.nemesis         p:INFO  > sdcm.nemesis.GrowIncrementalMonkey: Interval: 60 s
20:48:22  < t:2025-02-19 18:48:22,623 f:nemesis.py      l:460  c:sdcm.nemesis         p:INFO  > sdcm.nemesis.GrowIncrementalMonkey: Current Target: Node elasticity-test-grow-l-8-db-node-44943038-2 [54.217.43.24 | 10.4.2.246] with running nemesis: GrowIncremental
20:48:22  < t:2025-02-19 18:48:22,646 f:nemesis.py      l:1331 c:sdcm.nemesis         p:INFO  > sdcm.nemesis.GrowIncrementalMonkey: Adding 1 new nodes to cluster...
20:48:22  < t:2025-02-19 18:48:22,651 f:cluster_aws.py  l:405  c:sdcm.cluster         p:INFO  > Cluster elasticity-test-grow-l-8-db-cluster-44943038 (AMI: ['ami-0730f2ca76fe9bd91'] Type: i4i.large): rack distribution: [1]
20:48:22  < t:2025-02-19 18:48:22,652 f:cluster_aws.py  l:233  c:sdcm.cluster         p:INFO  > Cluster elasticity-test-grow-l-8-db-cluster-44943038 (AMI: ['ami-0730f2ca76fe9bd91'] Type: i4i.large): Create on_demand instance(s)
20:48:22  < t:2025-02-19 18:48:22,653 f:file_logger.py  l:101  c:sdcm.sct_events.file_logger p:INFO  > 2025-02-19 18:48:22.646: (InfoEvent Severity.NORMAL) period_type=not-set event_id=25f2081f-39c9-4fce-98f1-94c9ae050615: message=StartEvent - Adding 1 new nodes to cluster
20:48:42  < t:2025-02-19 18:48:41,446 f:cloud_init.py   l:32   c:sdcm.provision.helpers.cloud_init p:INFO  > Waiting for cloud-init to complete on node elasticity-test-grow-l-8-db-node-44943038-4...
20:48:59  < t:2025-02-19 18:48:58,184 f:cluster.py      l:601  c:sdcm.cluster_aws     p:INFO  > Node elasticity-test-grow-l-8-db-node-44943038-4 [54.75.59.22 | 10.4.0.119]: Detected Linux distribution: UBUNTU24
20:49:00  < t:2025-02-19 18:48:59,815 f:cluster.py      l:1151 c:sdcm.cluster_aws     p:INFO  > Node elasticity-test-grow-l-8-db-node-44943038-4 [54.75.59.22 | 10.4.0.119]: node_type = db
20:49:00  < t:2025-02-19 18:48:59,987 f:cluster.py      l:568  c:sdcm.cluster_aws     p:INFO  > Node elasticity-test-grow-l-8-db-node-44943038-4 [54.75.59.22 | 10.4.0.119]: Keep this node alive
20:49:10  < t:2025-02-19 18:49:09,989 f:cluster.py      l:4701 c:sdcm.cluster         p:INFO  > Cluster elasticity-test-grow-l-8-db-cluster-44943038 (AMI: ['ami-0730f2ca76fe9bd91'] Type: i4i.large): Waiting for preinstalled Scylla
20:49:10  < t:2025-02-19 18:49:09,989 f:cluster.py      l:2987 c:sdcm.cluster_aws     p:INFO  > Node elasticity-test-grow-l-8-db-node-44943038-4 [54.75.59.22 | 10.4.0.119]: Waiting for Scylla Machine Image setup to finish...
20:49:10  < t:2025-02-19 18:49:10,033 f:cluster.py      l:4703 c:sdcm.cluster         p:INFO  > Cluster elasticity-test-grow-l-8-db-cluster-44943038 (AMI: ['ami-0730f2ca76fe9bd91'] Type: i4i.large): Done waiting for preinstalled Scylla

[cezarmoise]

I understand that the logs refer to the cluster, which was originally a i4i.large cluster, but there is no mention of the added node's instance type anywhere.

[fruch]

I would recommend taking the instance type out of the cluster prints, and move every print that refer to a node, to the node logger and add the instance type there, on the node logger.

[dimakr]

Proper instance type logging is added in https://github.com/scylladb/scylla-cluster-tests/pull/11909