java-driver icon indicating copy to clipboard operation
java-driver copied to clipboard

Fix disabled integration tests on branch 3.x when running against Scylla

Open avelanarius opened this issue 4 years ago • 0 comments

Some integration tests were disabled in #94, as they did not pass against Scylla. Some of them were disabled due to testing Cassandra-specific functionality (unavailable in Scylla), but some of them look like real potential issues.

Fix those tests and re-enable them. Some tags in comments to look for:

  • @IntegrationTestDisabledScyllaFailure - general regression when running with Scylla
  • @IntegrationTestDisabledScyllaJVMArgs - disabling test, when running with Scylla, that uses Cassandra's JVM arguments
  • @IntegrationTestDisabledScyllaQueryTrace - disabling test, when running with Scylla, that uses Cassandra's query tracing (hardcoded messages)
  • @IntegrationTestDisabledScyllaUDF - disabling test, when running with Scylla, that uses Cassandra's UDF implementation
  • @IntegrationTestDisabledScyllaUnsupportedFunctionality - disabling test, when running with Scylla, that uses functionality unsupported by Scylla (for example SASI indexes or Cassandra's CDC)
  • @IntegrationTestDisabledScyllaUnsupportedIndex - disabling test, when running with Scylla, that uses Cassandra's indexes unsupported by Scylla
  • @IntegrationTestDisabledSSL - a disabled test that also happens to test SSL functionality

Note that fixing some tests (such as https://github.com/scylladb/java-driver/blob/scylla-3.x/driver-core/src/test/java/com/datastax/driver/core/TableMetadataCDCTest.java) will require writing a new Scylla-specific test (in this example a test of parsing Scylla's CDC metadata).

avelanarius avatar Sep 09 '21 09:09 avelanarius