java-driver icon indicating copy to clipboard operation
java-driver copied to clipboard
verified publisher icon scylladb

docs: add default branch

Open dgarcia360 opened this issue 1 year ago • 5 comments

Adds default branch to the docs fix the "Edit this page" button.

dgarcia360 avatar Jul 02 '24 15:07 dgarcia360

What about the driver 4.x? Will the edit button just not work for it?

Lorak-mmk avatar Jul 05 '24 08:07 Lorak-mmk

I'm assuming that for 4.x we need similar PR for scylla-4.x branch

Bouncheck avatar Jul 05 '24 08:07 Bouncheck

Maybe that's wrong assumption though. How is final documentation page created? I'm not sure who maintains it. Is it a result of make multiversion or is it a combination of a build made on 3.x branch and a separate one on 4.x branch? Because in make multiversionpreview it does indeed result in pointing to 3.x branch for 4.x versions too.

Bouncheck avatar Jul 05 '24 09:07 Bouncheck

It seems that on 4.x branch the docs directory is a copy of 3.x one. Looks like one made for convenience sake and that we do not maintain different configuration for 4.x. So if we create multi version (including 4.x) documentation from 3.x branch we should not be defaulting to 3.x urls for all versions. Thanks for the catch @Lorak-mmk.

Bouncheck avatar Jul 05 '24 10:07 Bouncheck

@dgarcia360 , could you please take a look at https://github.com/scylladb/sphinx-scylladb-theme/issues/1156 before merging it.

dkropachev avatar Jul 30 '24 13:07 dkropachev

Replaced by https://github.com/scylladb/java-driver/pull/367

dgarcia360 avatar Nov 12 '24 11:11 dgarcia360