java-driver icon indicating copy to clipboard operation
java-driver copied to clipboard

CI is running against Scylla 5.3.0-rc0?!

Open mykaul opened this issue 1 year ago • 4 comments

I'm not sure why, but this is a completely outdated version. Please move to latest 5.4.x.

mykaul avatar Apr 25 '24 08:04 mykaul

Looks like the CI pulls all the relevant scylla tags from dockerhub by this script and parameters: python3 ci/version_fetch.py scylla-oss-stable:2 scylla-oss-rc scylla-enterprise-stable:2 scylla-enterprise-rc Which indeed returned: ["2023.1.7", "5.2.17", "2024.1.3", "5.4.6", "5.3.0-rc0"]

As a first remediation, I removed the '5.3.0-rc0' tag from our dockerhub since there is no such version. This case was a "special case" that the script couldn't handle since we skipped this version and didn't release it.

However, it brings me to the question, do we really want to run the CI with the parameter of fetching the OSS RC releases?

roydahan avatar Apr 25 '24 11:04 roydahan

This is the current result of the script after removing the 5.3.0-rc0 tag from dockerhub:

 python /Users/roy/Downloads/version_fetch.py scylla-oss-stable:2 scylla-oss-rc scylla-enterprise-stable:2 scylla-enterprise-rc
["2024.1.3", "5.4.6", "5.2.17", "2023.1.7"]

roydahan avatar Apr 25 '24 11:04 roydahan

However, it brings me to the question, do we really want to run the CI with the parameter of fetching the OSS RC releases?

The original rationale was to test the driver against pre-release Scylla versions to be able to catch some bugs earlier, but I admit that the java-driver-matrix probably is a better place to catch it, not this repo.

avelanarius avatar Apr 25 '24 11:04 avelanarius

Sent PR to ignore oss-rc in CI.

roydahan avatar Apr 25 '24 12:04 roydahan