java-driver icon indicating copy to clipboard operation
java-driver copied to clipboard

Don't limit `scylla.version` to actual version number

Open fruch opened this issue 2 years ago • 5 comments

there are cases we want to use CCM with non-released versions, like:

unstable/master:latest
13812adsaf # version crafted from a local unified package, and uses scylla sha, this is how it in all places we run in jenkins: dtest/python-matrix and such

and this break the following code paths:

installArgs.add("-v release:" + inputScyllaVersion); ... GLOBAL_SCYLLA_VERSION_NUMBER = VersionNumber.parse(inputScyllaVersion);

fruch avatar May 24 '23 14:05 fruch

I'll share the example of how to get an actual version sting out of CCM, without running a version

fruch avatar May 24 '23 14:05 fruch

so basically we need to run this with the version (it would download and cache it, for next cluster it create)

❯ ccm create get_version -n 1 --scylla --version unstable/master:latest
Current cluster is now: get_version
❯ ccm node1 versionfrombuild
5.4.0-dev
❯ ccm remove

fruch avatar May 24 '23 14:05 fruch

It's depend on this CCM fix, to work without starting a node: https://github.com/scylladb/scylla-ccm/pull/458

fruch avatar May 24 '23 14:05 fruch

@k0machi isn't this already fixed in matrix tests?

avelanarius avatar Jan 15 '24 15:01 avelanarius

@k0machi isn't this already fixed in matrix tests?

No, patched and hardcoded it to some number for now.

fruch avatar Jan 15 '24 16:01 fruch