minicps icon indicating copy to clipboard operation
minicps copied to clipboard

Published 20 hours ago • verified publisher icon scy-phy

feature/enip2

Open aporan opened this issue 7 years ago • 9 comments

Notes:

  1. server still doesn't support multikey yet read/write yet, so it will respond with a proper error message.
  2. server still needs to take in log files.
  3. Pipe out messages from single_read and single_write script to the api.

aporan avatar Apr 07 '17 10:04 aporan

Make sure same API without datatype.

francozappa avatar Apr 27 '17 11:04 francozappa

@remmihsorp

Make sure that it can be installed adding it to the requirements.txt and setup.py.

Is it really necessary to depend upon a fork of pycomm?

francozappa avatar May 02 '17 00:05 francozappa

  1. Noted.
  2. Unfortunately, yes it does.

aporan avatar May 02 '17 00:05 aporan

Make sure that we add eq_ tests Make sure that we return only the (string) value from _receive Use our modbus implementation as a reference

francozappa avatar May 03 '17 10:05 francozappa

I have also updated my enipserver, you'd need to pull the latest changes.

aporan avatar May 05 '17 01:05 aporan

Thanks @remmihsorp .

Can you please remove the newline from the return value, eg:

plc1.receive(SENSOR2, PLC2_IP)

should return '1' and not '1\n'

p.s. Travis is failing because we don't have packaged enipserver and the pycomm fork

francozappa avatar May 05 '17 02:05 francozappa

Hi @remmihsorp,

What is the status of the package?

francozappa avatar Jun 22 '17 01:06 francozappa

Hi @francozappa, i have paused the development of the branch for a while as i have extensively changed (changing) the enipserver api. Hopefully, I aim to finish a complete refactoring of by next week, and then should be able proceed working on the feature/enip2 agian promptly.

aporan avatar Jun 22 '17 02:06 aporan

Hi @francozappa, I have tested the new additions inside a vm. The tests passes on my side. Provided that enipserver is not available as a package, you'd need to manually clone remmihsorp/pycomm and scy-phy/enipserver, add both pycomm and enipserver to PYTHONPATH to tests the changes on your side.

Thanks!

Also, enipserver now has udp messaging. Perhaps, we can think of test scenario to incorporate that.

aporan avatar Jul 25 '17 04:07 aporan