Chen Shen
Chen Shen
ah this run_on_all_workers is annoying
most of test failures are around logging. we need to merge https://github.com/ray-project/ray/pull/31772 first
better leave this to @kevin85421 and @DmitriGekhtman to review
Thanks for reporting. I think there is some race condition between Ray GC and spill worker, so when the object has been GCed the spill worker already grab the object...
sounds reasonable to me.
@zcin this breaks bk://:java and bk://:mac: :apple: Ray C++ and Java
[Core][deprecate run_on_all_workers 1/n] set worker's sys.path through JobConfig._py_driver_sys_path
> Btw, could you also delete import thread which is not useful anymore with this work. Deletion will be done in https://github.com/ray-project/ray/pull/30895, since @rkooo567 has some concern on deprecation logistic.
[Core][deprecate run_on_all_workers 1/n] set worker's sys.path through JobConfig._py_driver_sys_path
> Thanks for fixing this. As synced offline, my only concern is that we make the code_search_path and the new introduced ones doing similar works. Maybe we should try to...
Thanks for the detailed explaination. For my understanding, it looks like a bug that we still accepting chunks after step 9. Since at this point we should know the object...
hmm i see. yeah let's implement proposal 1 given how simple it is?