Jason

Results 93 comments of Jason

@vjvijaysekar Is there a publicly accessible example that you can share? Is this something that you can reliably replicate?

This depends on #1473

🚨 Reviewed for Security 🚨

I've performed a functional assessment of each component to determine their compatibility with React 17. This is by no means comprehensive, but is testing the expected behavior of each component...

There's a possibility that we could unofficially support React 17/18, I'm not seeing any breaking changes for 17. We could temporarily use this [third party adapter](https://www.npmjs.com/package/@wojtekmaj/enzyme-adapter-react-17) to allow cauldron to...

It looks like there's some breaking changes with [v18](https://reactjs.org/blog/2022/03/08/react-18-upgrade-guide.html): * [updates to type definitions](https://reactjs.org/blog/2022/03/08/react-18-upgrade-guide.html#updates-to-typescript-definitions) * [event automatic batching](https://reactjs.org/blog/2022/03/08/react-18-upgrade-guide.html#automatic-batching) * changes to `useEffect` timings

> The modals break when you upgrade to `react-dom` 17. Modal toggle is called twice on open in `4.7.0-canary.a816b304` (fix from Pr #698) and four times with `4.7.0-canary.87de5e62`. It appears...

For the first example, we're showing 2 examples of of the same component with its default label that we shouldn't directly change because they're specifically examples that would ideally be...

After discussing with @VaniChinnam and subject matter experts the path forward is to add an `aria-described` to the toggle button so that we can meet in the middle.

Investigate different sizing (e.g. smaller icons potentially) as an alternate variant.