scuniff

Repeated conditional tests

2

https://github.com/ome/bioformats/blob/077ed120c9884af6f8cd7932e4156ac910d471b4/components/formats-bsd/src/loci/formats/out/DicomWriter.java#L1869 DimensionOrder order = retrieve.getPixelsDimensionOrder(series); return sequential && (sizeC == 1 || sizeZ == 1 || order == DimensionOrder.XYZCT || order == DimensionOrder.XYZTC || order == DimensionOrder.XYZTC || order ==...

Argument #1 to org.joda.time.DateTime is declared as a long but an int is being passed in MetamorphReader.decodeTime(int millis).

1

Not entirely sure about all of this, but…. Regarding https://github.com/ome/bioformats/blob/ff123626d95e245715a8ca4390d69d9418cde037/components/formats-gpl/src/loci/formats/in/MetamorphReader.java#L2051 Line 2051 DateTime tm = new DateTime(millis, DateTimeZone.UTC); Argument #1 to org.joda.time.DateTime is declared as a long but an int...

ImageJ 1.54f Exception in thread "Pixel Inspector" java.lang.NullPointerException at ij.plugin.tool.PixelInspector.addImageListeners(PixelInspectionTool.java:238) at ij.plugin.tool.PixelInspector.writeNumbers(PixelInspectionTool.java:351) at ij.plugin.tool.PixelInspector.run(PixelInspectionTool.java:330) at java.lang.Thread.run(Thread.java:748) Steps: 1. Open up Fiji 2. Select Pixel Inspection Tool on Toolbar 3. Open...

Call to equals() always returns false

1

The following should probably be reviewed: https://github.com/imagej/ImageJ/blob/master/ij/gui/ImageWindow.java Line 458 if (initialLoc!=null && ! **bounds.equals(initialLoc)** && !IJ.isMacro() Referring to the code: **bounds.equals(initialLoc)** variable bounds is of type java.awt.Rectangle variable initialLoc is...

1) [ImageJ/Memory.java at master · imagej/ImageJ · GitHub](https://github.com/imagej/ImageJ/blob/master/ij/plugin/Memory.java) Semi-colon at end of 2’nd if statement creates an empty statement block so the return statement is always executed. if (max2>=limit &&...

The Static Code Analyzer Spot Bugs found the following issues with Strings being compared with either == or != and should be using **equals()**. **From Spot Bugs:** Comparison of String...

Strings are being compared with == and !=

1

2 occurrences where 2 Strings are being compared with == and !=. They should be using String.equals() https://github.com/ome/bioformats/blob/6fa35f6deb652ac34e3bb2fba5b8b694481d3585/components/formats-bsd/src/loci/formats/gui/PreviewPane.java#L218 https://github.com/ome/bioformats/blob/6fa35f6deb652ac34e3bb2fba5b8b694481d3585/components/formats-bsd/src/loci/formats/gui/PreviewPane.java#L263 should be? Line 218 if (id.equals(lastId)) continue; Line 263 if (!id.equals(loadId))...

https://github.com/ome/bioformats/blob/682bc7e318b88f159d3c6e2603fb82fb9d613268/components/formats-bsd/src/loci/formats/dicom/DicomTag.java#L353 **location** is an argument to this constructor and so it being incremented won’t be seen outside this constructor. **location** getting updated doesn't seem to be used anywhere else in...

https://github.com/ome/bioformats/blob/678fd01d88b24208188683db77f293b0ff34e11f/components/formats-bsd/src/loci/formats/tiff/TiffParser.java#L199-L220 Referring to above, there are 3 places in method **checkHeader()** a null is returned. This will cause a Null Pointer Exception for those callers that are returned the result...

Cast to double may be needed

1

https://github.com/ome/bioformats/blob/0a895ae7e7895e9193c02139ca51189fe5b9c106/components/formats-gpl/src/loci/formats/in/FV1000Reader.java#L1348-L1349 Since **width** and **height** are ints, the equation is done with Integer accuracy and not Double accuracy. To get Double accuracy from the equations, a **double** cast is needed...