scummvm-web icon indicating copy to clipboard operation
scummvm-web copied to clipboard

WEB: Improve OpenGraph headers

Open lephilousophe opened this issue 1 year ago • 1 comments

Improve the OpenGraph result by diversifying the description and the title. This is done by adding more template parameters that each Controller sets to the proper value depending on the context. This allows a better rendering than in #393.

lephilousophe avatar Sep 06 '24 15:09 lephilousophe

"better" is a subjective term. For example, I've fixed <title> while you didn't. I've also found a way to dynamically generate a meta description on the fly, which could be served as else to your check of if isset($description). Other differences are in here - as suggested there, why not just editing it to add your features there, and thus enjoy both my features and yours?

In any case, please apply your own fix of og:title also to <title>.

lwcorp avatar Sep 06 '24 20:09 lwcorp

This is updated to add subtitle to the page title. In addition, the news page title gains a dedicated string. There is now Home for the home page and Latest developments (ripped from the content title) for the news archive page. This title can be changed afterwards.

lephilousophe avatar Sep 08 '24 08:09 lephilousophe

Merging now. I just added a change so that the page description when showing a game compatibility is the compatibility status. This will allow to link a game compatibility page and get a nice "Game has no known issue" in the preview.

lephilousophe avatar Sep 14 '24 11:09 lephilousophe

~Though it's merged it seems it's still not live, do you happen to know the ETA?~ Update: took the merge about half a day to go live. BTW, out of curiosity how were you able to get write access, which is required for assigning reviewers and merging?

lwcorp avatar Sep 14 '24 12:09 lwcorp