lespas icon indicating copy to clipboard operation
lespas copied to clipboard

Limit "10% space remaining" warning

Open DeveloperOl opened this issue 2 years ago • 5 comments

Lespas warns me when I have low storage left on my device which is a good thing in general. However the 10% limit is a bad idea in my opinion. I have 256Gb on my phone and 23Gb left. So everytime I open lespas I get a storage warning even though I wouldn't consider the situation critical.

It would be a great idea to limit the warning to an absolute maximum for example: Warn me when I have less than 10% storage left and less than 5Gb.

DeveloperOl avatar Jul 31 '22 18:07 DeveloperOl

Les Pas depends on Android system sync adapter to do all the syncing. Sync adapter would stop itself from running without any notice when your internal storage have 10% or less space left. So this is all about sync with server got weired, considering your another issue #86. Of course, the incorrect status reporting of all items synced is indeed a bug.

scubajeff avatar Aug 01 '22 00:08 scubajeff

okay I don't mind this too much but it can become a problem when devices get even larger storage in the near future. However the warning comes from lespas and not from android, so still a "don't remind me again" option would be good?

DeveloperOl avatar Aug 14 '22 16:08 DeveloperOl

Considering that it will ruin the core function of syncing and album sharing/publishing, I would prefer the more aggressive way to warn the users.

I have a plan to refactor the syncing code using WorkManager instead of SyncAdapter, then this issue will be solved and I also gain more control of the sync process so that the much mentioned sync status display feature can be implememted.

scubajeff avatar Aug 15 '22 01:08 scubajeff

I was wondering if it would be possible to avoid this restriction by using an external SD as main storage for the app. In system settings is possible to move all the data of the app from the internal storage to the SD but the warning is still there despite there is plenty space in the SD.

darguez avatar Aug 28 '22 15:08 darguez

That function move app's data folder to SD, if your albums are all 'Remote', that won't help much. I'm not quite sure if it effectively moves cache portion too.

scubajeff avatar Aug 28 '22 23:08 scubajeff