overseerr icon indicating copy to clipboard operation
overseerr copied to clipboard

Published 20 hours ago • verified publisher icon sct

feat: fallback to text format implemented for Telegram notifications

Open mralien opened this issue 3 years ago • 9 comments

fix #3064, #3100

Description

Added fallback to simple text notification for Telegram channel. Sometimes sendPhoto API method returns 400 error with "wrong file identifier/HTTP URL specified" description while in reality poster is available, and in result no one receives notifications related to this request.

Example 1 (successful photo notification): The Woman King (2022), tmdb:724495 Example 2 (failed photo notification, falling back to text): Hex (2022), tmdb:988233

To-Dos

  • [x] Successful build yarn build
  • [ ] Translation keys yarn i18n:extract / nothing related to UI was changed
  • [ ] Database migration (if required)

Issues Fixed or Closed

  • Fixes #3064
  • Fixes #3100

mralien avatar Dec 04 '22 18:12 mralien

For some reason after I built and redeployed my overseerr instance with master + cherry-pick of my commit, even Hex movie start working. But while I was testing everything with plain 1.30.1 it didn't.

mralien avatar Dec 06 '22 19:12 mralien

For some reason after I built and redeployed my overseerr instance with master + cherry-pick of my commit, even Hex movie start working. But while I was testing everything with plain 1.30.1 it didn't.

To clarify, is this PR still needed? Or is it working as expected?

sct avatar Dec 31 '22 13:12 sct

I think this PR still needed. Even though Hex (2022, tmdb:988233) works right now with latest official docker image, media without poster at all doesn't produce Telegram notifications - checked on movie (or short movie) HEX (tmdb:593281).

It wouldn't harm either way, because no one can predict when and why poster for any movie/TV show might become unavailable.

update: rebased branch on current develop state

mralien avatar Jan 02 '23 15:01 mralien

I'm interested in this fix, wondering if there's activity happening to get this merged. Thanks

DavidJuanes avatar Feb 12 '23 13:02 DavidJuanes

I'm also very interested in this fix. I hope it can be part of the next release. Is there anything that can be done to speed up the process?

freakshock88 avatar Feb 17 '23 11:02 freakshock88

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar May 08 '23 17:05 stale[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 15 '23 02:07 stale[bot]

I can confirm this is still needed.

2023-12-07T19:23:19.767Z [error][Notifications]: Error sending Telegram notification {"type":"MEDIA_AUTO_APPROVED","subject":"Willy Wonka & the Chocolate Factory (1971)","errorMessage":"Request failed with status code 400","response":{"ok":false,"error_code":400,"description":"Bad Request: wrong file identifier/HTTP URL specified"}}

PCJones avatar Dec 07 '23 21:12 PCJones

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 13 '24 09:03 stale[bot]

I closed it since no one found time to review this PR in 2.5 years. Custom docker image with PR applied available at https://hub.docker.com/r/blackop/overseerr

mralien avatar Sep 03 '25 17:09 mralien