overseerr icon indicating copy to clipboard operation
overseerr copied to clipboard

feat: decouple Plex as a requirement for setting up/using Overseerr

Open sct opened this issue 2 years ago • 17 comments

Description

This is the first step to opening up Overseerr to allow other media server integrations. Previously, Overseerr required signing in with a Plex account to get it configured. You can now create a local account instead of using Plex. If a local account is used, you will need to connect your Plex account still to use the Plex Media Server features.

Screenshot (if UI-related)

image image

To-Dos

  • [x] Decouple plex from the setup process
  • [x] Remove UserType from users (opens possibility for multiple user types per user)
  • [x] Add option to link/unlink Plex account from user settings (instead of only while logging in)
  • [ ] Allow changing emails
  • [x] Disable Plex login when owner account does not have plex configured
  • [x] Do not allow new plex connections to accounts if owner account unlinks plex
  • [ ] Successful build yarn build
  • [ ] Translation keys yarn i18n:extract
  • [ ] Database migration (if required)

sct avatar Sep 12 '22 02:09 sct

This pull request introduces 1 alert when merging a231eba896051044372a48a1da715dba81cbfd3e into 30141f76e025763bf79fd3c8fb344d45519d5d8d - view on LGTM.com

new alerts:

  • 1 for Useless conditional

lgtm-com[bot] avatar Sep 12 '22 02:09 lgtm-com[bot]

1 flaky tests on run #2043 ↗︎

0 28 0 0 Flakiness 1

Details:

feat: decouple Plex as a requirement for setting up/using Overseerr
Project: overseerr Commit: abcf78f966
Status: Passed Duration: 05:02 💡
Started: Aug 6, 2023 7:43 AM Ended: Aug 6, 2023 7:48 AM
Flakiness  cypress/e2e/settings/discover-customization.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Discover Customization > can create a new discover option and remove it Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

cypress[bot] avatar Sep 12 '22 02:09 cypress[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Nov 13 '22 19:11 stale[bot]

For those who have patiently been waiting for this, it's still in progress! I am trying to sneak in time to get this done this new year's vacation. It's super close, so please wait just a little bit longer! 🙏

sct avatar Dec 29 '22 13:12 sct

I'm looking forward for this 🎉

DimitriDR avatar Jan 13 '23 16:01 DimitriDR

Hey @sct! Just checking in and seeing how this is going. This is the final piece of the puzzle for me. Hope you've had a wonderful New Year's vacation!

sypion avatar Feb 04 '23 06:02 sypion

Hey @sct! Just checking in and seeing how this is going. This is the final piece of the puzzle for me. Hope you've had a wonderful New Year's vacation!

We are still working on it!

sct avatar Feb 04 '23 06:02 sct

Is there a way to help, and most importantly, what is the estimated release date?

That's crucial information because a very viable and full featured release already exists with Jellyseerr, so if there isn't a near term road map folks will want to use that instead. Are you working with the Jellyseerr developers to pull in their improvements?

If the release date is significantly distant, it'd make sense to focus on a migration path for Jellyseerr, as well as to double down on collaboration with the devs of that project.

Please let us know the best way to collaborate to get this feature released.

brettp avatar Feb 04 '23 07:02 brettp

Is there a way to help, and most importantly, what is the estimated release date?

That's crucial information because a very viable and full featured release already exists with Jellyseerr, so if there isn't a near term road map folks will want to use that instead. Are you working with the Jellyseerr developers to pull in their improvements?

If the release date is significantly distant, it'd make sense to focus on a migration path for Jellyseerr, as well as to double down on collaboration with the devs of that project.

Please let us know the best way to collaborate to get this feature released.

We don't provide ETAs. We spare whatever free time we have and that's the best I can tell you in terms of delivery time.

I am aware of Jellyseerr. That's the beauty of open source. We also now have an internal roadmap with Jellyseerr devs we are referencing to get Jellyfin support back ported to Overseerr once this is merged.

I know people are waiting for this. It's close. Just hang on a bit longer.

sct avatar Feb 04 '23 09:02 sct

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar May 01 '23 15:05 stale[bot]

f*ck you stale bot

aleksasiriski avatar May 01 '23 15:05 aleksasiriski

Can't wait for this to be merged. I assume this is purely a structural change to allow for jellyfin/emby but doesn't directly add them?

CEbbinghaus avatar May 30 '23 14:05 CEbbinghaus

Has there been any movement here?

I have still have #3105 open which was tacitly waiting on this work to shake out, but it's not clear to me if this work has stalled entirely or what.

tobz avatar Jun 23 '23 01:06 tobz

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Oct 15 '23 06:10 stale[bot]

yikes. Unstale please

CEbbinghaus avatar Oct 15 '23 07:10 CEbbinghaus

I suggest adding the never-stale label to avoid our friendly stale-bot freaking folks out as core careful decoupling like this takes a lotta time and effort to get right.

mattkatz avatar Oct 24 '23 10:10 mattkatz

Is this still being worked on?

Emalton avatar Apr 07 '24 20:04 Emalton