overseerr icon indicating copy to clipboard operation
overseerr copied to clipboard

Commit Tag on startup shows $GITHUB_SHA

Open adamus1red opened this issue 2 years ago • 1 comments

Description

It appears that the $GITHUB_SHA variable is not being correctly expanded to be the actual correct value as part of the docker container build. This means that the litteral string $GITHUB_SHA is appearing in the logs rather than the sha of the commit it was built from.

Version

1.29.1

Steps to Reproduce

  1. Pull sct/overseerr:latest container image
  2. Start sct/overseerr:latest container
  3. look at the logs.

Screenshots

image

Logs

plex-overseerr-1  | yarn run v1.22.18
plex-overseerr-1  | $ NODE_ENV=production node dist/index.js
plex-overseerr-1  | 2022-06-16T10:25:57.803Z [info]: Commit Tag: $GITHUB_SHA
plex-overseerr-1  | 2022-06-16T10:25:57.948Z [info]: Starting Overseerr version 1.29.1
plex-overseerr-1  | 2022-06-16T10:26:09.989Z [info][Notifications]: Registered notification agents
plex-overseerr-1  | 2022-06-16T10:26:10.072Z [info][Jobs]: Scheduled jobs loaded
plex-overseerr-1  | 2022-06-16T10:26:10.562Z [info][Server]: Server ready on port 5055

Platform

desktop

Device

docker

Operating System

Debian 11

Browser

N/A

Additional Context

No response

Code of Conduct

  • [X] I agree to follow Overseerr's Code of Conduct

adamus1red avatar Jun 16 '22 10:06 adamus1red

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Aug 15 '22 22:08 stale[bot]

:tada: This issue has been resolved in version 1.31.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Dec 17 '22 03:12 github-actions[bot]