overseerr icon indicating copy to clipboard operation
overseerr copied to clipboard

Bulk Edit - Show existing user permissions

Open farhills opened this issue 2 years ago • 5 comments

Description

I recently used the bulk edit feature to give my users permission to report issues. I assumed that the permissions would follow 'standard' behaviour where existing permissions are inherited, and in a rush just ticked the boxes for report issues. In the process, I nuked everyone's request permissions, including both the defaults as well as a few elevated users.

I eventually figured it out and got things sorted - not a huge deal, the feature just didn't work the way I expected.

Desired Behavior

It would be preferred if the Bulk Edit feature followed more 'standard' behaviour (eg. when changing windows file permissions) where existing permissions are inherited and shown on the page. In the case of 'mixed' permissions (where only a subset of the selected users have been granted), these would be shown with a half-filled check box.

In other words, only permissions explicitly changed by the admin should be modified.

Additional Context

No response

Code of Conduct

  • [X] I agree to follow Overseerr's Code of Conduct

farhills avatar Apr 04 '22 03:04 farhills

We already show the users' permissions when you bulk edit, but ONLY if the users you are bulk editing already have the exact same permissions.

e: I don't see how a half ticked box solves this since you will run into the same issue with users' being given (or not) unexpected permissions.

sct avatar Apr 04 '22 03:04 sct

I guess from your perspective the permissions on the bulk edit form get written directly to the list of users?

Assuming that's the case then I would reword my request to skip writing to any fields where mixed permissions are detected.

e The half tick box represents a mixed data field that would be skipped. If the admin chooses, they could overwrite all by clicking that box to apply/remove that permission to the full group.

Really appreciate the software and the time you and the crew have put into it! Your decision is respected either way 😁👍

farhills avatar Apr 04 '22 04:04 farhills

Not a bad idea. Would need to think about how we would implement that. I will leave this open to discussion to see what the rest of the team thinks then.

sct avatar Apr 04 '22 05:04 sct

I was planning on working on this sometime because it really limits the bulk edit functionality imo, and unfortunately without that it's not really as useful as it could be. And the half checkbox is exactly what I had in mind. The bulk edit functionality also overwrites all existing user permissions, which I think it shouldn't do. Instead, it should add/remove the specified permissions from every user's permissions instead of overwriting them altogether.

danshilm avatar Apr 04 '22 07:04 danshilm

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 04 '22 03:06 stale[bot]