overseerr
overseerr copied to clipboard
sct
feat(login): allow Plex OAuth to be disabled when reqs are met
Description
This PR adds a setting to allow admins to disable Plex OAuth as a sign-in method if the following requirements are met:
- the server owner has a password configured for their Overseerr account
- an application URL has been configured
- email notifications are enabled
The logic behind the last two requirements is that users without passwords will be able to use the password reset flow to create passwords and sign into their accounts.
Also refactors Login component to ease the addition of additional login options in the future and reduce duplicated code/logic, and tweaks the styling to match the changes we've made to other parts of the app.
Screenshot (if UI-related)
To-Dos
- [x] Successful build
yarn build - [x] Translation keys
yarn i18n:extract
Issues Fixed or Closed
- Closes #2557
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
bump
Test summary
24 • 
0 • 
0 • 
0 • 
0
Run details
| Project | overseerr |
| Status | Passed |
| Commit | bba921333b |
| Started | Aug 29, 2022 6:28 AM |
| Ended | Aug 29, 2022 6:35 AM |
| Duration | 06:21 💡 |
| OS | Linux Ubuntu - 20.04 |
| Browser | Electron 102  |
View run in Cypress Dashboard ➡️
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard
![cypress[bot] avatar](https://avatars.githubusercontent.com/in/9078?v=4 "Published by a pub.dev verified publisher"){kind=small}
Looks like this feature (thanks for your amazing work @TheCatLady) has been awaiting review from @sct , @samwiseg0, and @danshilm for a while. Is this likely to be merged?
Looks like this feature (thanks for your amazing work @TheCatLady) has been awaiting review from @sct , @samwiseg0, and @danshilm for a while. Is this likely to be merged?
We are currently working on a change that decouples the requirement to use Plex with Overseerr which will fundamentally change how this PR works. So for now, it's on hold.
Nevermind, just read the thread, either way, thank you so much everyone for getting this in the works and in process.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.