overseerr fix(ui): hide 'Recently Added' & 'Recent Requests' sliders when empty

Description

If the Recently Added and/or Recent Requests sliders are empty, hide them instead of taking up valuable screen real estate to display nothing. 😉

Also fixes a bug where users cannot click the Recent Requests slider heading in their profiles to view their own requests unless they have manage/view request perms.

Screenshot (if UI-related)

N/A

To-Dos

[x] Successful build yarn build

Issues Fixed or Closed

N/A

Oct 12 '21 22:10 TheCatLady

After a very small amount of use, these sliders are very rarely hidden so I am not sure what this really offers. I'd like users to know the sliders exist even when they are empty. It lets them know that the home page will have those items as soon as they start interacting with the app.

Oct 13 '21 04:10 sct

After a very small amount of use, these sliders are very rarely hidden so I am not sure what this really offers. I'd like users to know the sliders exist even when they are empty. It lets them know that the home page will have those items as soon as they start interacting with the app.

It doesn't really make sense to show an empty slider though, right? They'll just appear as soon as they request something or any media is available. And I don't think advertising the fact that these sliders exist when they are empty really offers much value. I think it feels much more natural for the new slider to just appear when there is actually content to be shown?

Also, one particular case to consider is where a user doesn't have request privileges and will never have requests to be displayed in the slider.

Oct 13 '21 04:10 TheCatLady

After a very small amount of use, these sliders are very rarely hidden so I am not sure what this really offers. I'd like users to know the sliders exist even when they are empty. It lets them know that the home page will have those items as soon as they start interacting with the app.

It doesn't really make sense to show an empty slider though, right? They'll just appear as soon as they request something or any media is available. And I don't think advertising the fact that these sliders exist when they are empty really offers much value. I think it feels much more natural for the new slider to just appear when there is actually content to be shown?

Also, one particular case to consider is where a user doesn't have request privileges and will never have requests to be displayed in the slider.

Yeah not sure I agree. I think this is still a core aspect of Overseerr and the cases in where these will remain empty is exceedingly rare. Also, a user may not have the requests permission but they may have had it at some point. So there is no saying whether or not they have requests at the moment.

Oct 13 '21 05:10 sct

Yeah not sure I agree. I think this is still a core aspect of Overseerr and the cases in where these will remain empty is exceedingly rare. Also, a user may not have the requests permission but they may have had it at some point. So there is no saying whether or not they have requests at the moment.

Yeah, this is definitely is not a super common case. But the way I'm thinking of it is, Overseerr's Discover page is a feed of sorts... and it's natural for things to appear in feeds only when they are applicable/relevant.

As for the case of the user without the request perms... yes, that is true. However, we would still display the slider if they had requests to view, and only hide it if the slider isn't relevant.

I also personally have a couple of new users who like to browse but haven't requested anything (not because they don't have request perms, but because they are overly polite/courteous), and the empty requests slider occupies a nontrivial chunk of screen real estate near the top of the page unnecessarily. They already know they haven't submitted any requests yet; there's no need to remind them every time they open Overseerr 😅

Oct 13 '21 05:10 TheCatLady

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

May 25 '22 21:05 stale[bot]

Test summary

24 • 0 • 0 • 0 • 0

Run details


Project	overseerr
Status	Passed
Commit	066def740b
Started	Aug 30, 2022 11:49 PM
Ended	Aug 30, 2022 11:51 PM
Duration	02:34 💡
OS	Linux Ubuntu - 20.04
Browser	Electron 102

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard