SecretNetwork icon indicating copy to clipboard operation
SecretNetwork copied to clipboard

Create codeql.yml

Open faddat opened this issue 2 years ago • 6 comments

Hey I think that this may need to run on a GR or we need to give it special permission to run on github actions but it's really really great.

It detects things like non-determinism errors.

faddat avatar Jul 14 '22 04:07 faddat

Is this static analysis magic?

assafmo avatar Jul 14 '22 05:07 assafmo

it is exactly the static analysis magic

faddat avatar Jul 14 '22 06:07 faddat

Very cool. Interested to see whether it will work out of the box, or if we'll need to tinker with it

Cashmaney avatar Jul 14 '22 09:07 Cashmaney

I find that setting the tag secretcli can help, locally. But also seems my local dev env "ain't quite right".

When I set the build tag, it works better but (eg: gopls) doesn't seem to work perfectly.

faddat avatar Jul 14 '22 13:07 faddat

I find that setting the tag secretcli can help, locally. But also seems my local dev env "ain't quite right".

When I set the build tag, it works better but (eg: gopls) doesn't seem to work perfectly.

The secretcli tag just compiles without the SGX enclave part, so it's not really a complete build.

Also, are we missing anything else for this action to run? I was expecting the codeql workflow to be available in this branch already 🤔

Cashmaney avatar Jul 17 '22 13:07 Cashmaney

@Cashmaney I believe the secretcli tag is used here to silence the VSCode IDE linkage errors

assafmo avatar Jul 19 '22 07:07 assafmo

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: dbb42ff
Status: ✅  Deploy successful!
Preview URL: https://778a69e1.swagger-preview.pages.dev
Branch Preview URL: https://faddat-codeql.swagger-preview.pages.dev

View logs

#1020

assafmo avatar Sep 08 '22 14:09 assafmo