contribute-to-scroll icon indicating copy to clipboard operation
contribute-to-scroll copied to clipboard

Add Scroll to SpaceSwap

Open blowflyv opened this issue 1 year ago • 0 comments

Name of the project

SpaceSwap

Project type

Tool

Site of the project

https://spaceswap.tech/

Github repository of the project

https://github.com/Space-Crypto-Project

Networks

Scroll Testnet - Sepolia, Scroll Mainnet

Additional context

Cross-Chain Bridge & DEX aggregator for seamless crypto transactions.

blowflyv avatar May 16 '24 12:05 blowflyv

Will definitely be looking into this

dbejarano820 avatar Jun 27 '23 21:06 dbejarano820

I would like to tackle this one 🤓

lana-shanghai avatar Jun 30 '23 09:06 lana-shanghai

I would like to tackle this one 🤓

please do!

AbdelStark avatar Jun 30 '23 09:06 AbdelStark

@abdelhamidbakhta how do we want to treat the sender field of the AsyncMessage? In the mikasa implementation we just take the signed origin and convert it with account_id_to_account_id32. With madara, do we want to use a deployed account?

lana-shanghai avatar Jul 07 '23 14:07 lana-shanghai

@abdelhamidbakhta how do we want to treat the sender field of the AsyncMessage? In the mikasa implementation we just take the signed origin and convert it with account_id_to_account_id32. With madara, do we want to use a deployed account?

I think so yes would make sense, account will always mean deployed account in the context of madara

EvolveArt avatar Jul 07 '23 14:07 EvolveArt

@EvolveArt should we keep track of which Substrate account deployed which account then? In that case we could check if the caller is indeed owner of that account in madara context

lana-shanghai avatar Jul 07 '23 14:07 lana-shanghai

OK I have an idea. I will use the H256 of a Substrate account as salt.

lana-shanghai avatar Jul 07 '23 14:07 lana-shanghai

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍 Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

github-actions[bot] avatar Aug 07 '23 00:08 github-actions[bot]

Can I help here?

andyjsbell avatar Aug 29 '23 20:08 andyjsbell

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍 Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

github-actions[bot] avatar Sep 29 '23 00:09 github-actions[bot]

repository archived in favor of https://github.com/madara-alliance/madara

tdelabro avatar Aug 02 '24 18:08 tdelabro