compute-scroll-into-view icon indicating copy to clipboard operation
compute-scroll-into-view copied to clipboard

compute-scroll-into-view doesn't cope with rtl layouts

Open MarkFalconbridge opened this issue 4 years ago • 2 comments

When the dir attribute of an ancestor node is set to "rtl" compute-scroll-into-view calculates the wrong scrollLeft positions.

To illustrate this I've created a jsfiddle - https://jsfiddle.net/6ckneau1/1/. When you click the "Scroll 7 into view" button in the LTR example it works just fine. When you click the "Scroll 7 into view" in the RTL example it doesn't scroll it into view.

The bug is caused by the way browsers report/use scrollLeft when in RTL. You may want to use a library like this https://github.com/alitaheri/normalize-scroll-left to address this issue.

MarkFalconbridge avatar Nov 19 '21 11:11 MarkFalconbridge

Hi !

I'm also trying to migrate all our scroll logic to this library, unfortunately RTL is indeed not working at all. Is there any plan to add support for RTL? :)

bakura10 avatar Oct 10 '23 07:10 bakura10

@MarkFalconbridge , I've pushed a PR that adds support for RTL (#907 )

I only tried a few use cases I had, feel free to try it and let me know if you are encountering edge cases.

bakura10 avatar Oct 10 '23 09:10 bakura10