jmdict-simplified icon indicating copy to clipboard operation
jmdict-simplified copied to clipboard

Fix "tm" g_type

Open fasiha opened this issue 1 year ago • 3 comments

New gloss type tm (™️) was causing an exception. PR fixes that.

Also, current JMdict_e.xml has TWO lines with the same tag:

<!ENTITY ik "word containing irregular kana usage">

which causes another exception, this PR fixes this too (in a somewhat fragile way: deduplicate repeated lines, via distinct, instead of duplicate tags).

The GitHub Actions ran and succeeded 🎉! https://github.com/fasiha/jmdict-simplified/runs/7710368295?check_suite_focus=true It finished in 7 minutes too (when I tried a local build on my macOS desktop from 2020, the convert step ran for over an hour without finishing 😢).

(The GitHub Actions release created an extra commit in my branch. I reverted this with git revert. So there are two useless commits in this PR. If you accept the PR and squash, then that shouldn't be a problem. Or, if you want me to force-push without those two commits, I can do that too!)

Also. I'm a 100% noob at XML so please feel free to close this if I've made a mess of things 😅!

fasiha avatar Aug 07 '22 05:08 fasiha

@scriptin we're thinking about you and hope you are doing ok ❤️!

In case anyone needs it, my cloned repo with this PR successfully ran the automated build job and you can download releases from https://github.com/fasiha/jmdict-simplified/releases until this repo's build is fixed.

fasiha avatar Aug 21 '22 07:08 fasiha

@fasiha Thank you! Last few months were a bit tough, but I'm doing okay.

I'll get back to the project soon, when I'll have some spare weekends and energy.

scriptin avatar Oct 11 '22 16:10 scriptin

@scriptin sending you good vibes! Take all the time you need 🤗

fasiha avatar Oct 11 '22 17:10 fasiha

Hello @fasiha!

I've just finished the new Kotlin converter. Please check out the new alpha release here. I expect some minor errors, but it looks pretty good.

It covers the changes in this PR:

  • The new tm value for g_type is supported properly
  • The issue with ik and iK tags only differing in case is resolved

I will close your PR as soon as somebody confirms that the new converter works properly. Nonetheless, thank you for your contribution, @fasiha!

scriptin avatar Dec 25 '22 19:12 scriptin