Scribe-iOS
Scribe-iOS copied to clipboard
scribe-org
Fix for inconsistent corners in certain views
Terms
- [X] I have searched open and closed design issues
- [X] I agree to follow Scribe-iOS' Code of Conduct
Description
The 1x1 view in the conjugation view (e.g. used for the Wikidata explanation) has slightly more rounded corners than the rest of the view's buttons. Either the more rounded corners or the more pointy corners should be used consistently instead. You get to a view like this by entering gibberish (for example "aaaaa") into any scribe functionality.
Example:
Close-up:
Contribution
I am available for any questions regarding this issue, I could also work on it myself at some point.
Hi @Jag-Marcel, I tried reproducing the issue. I do not see any inconsistency.
Please guide If I missed any thing!
Hey @Jag-Marcel 👋 Could you let us know what the simulator is that you're using so that @fabulouiOS-monk can try to reproduce?
@fabulouiOS-monk, something I'm wondering about as well: did you do anything to the shadow of the command bar you're looking at? The part that says "No en Wikidata". I'm wondering as it looks a lot darker than I'm expecting or in @Jag-Marcel's screenshots :)
Hey @andrewtavis, I didn't have any changes that would reflect a darker shadow. This screenshot is straight up from the cloned repo code.
Whoops, looks like I missed this, I tried using the main branch and the corners are normal, so it seems this is a bug introduced in my PR #415. I'm using a 15 pro simulator @andrewtavis, but it looks like the problem here was just that I forgot to check against my changes. The darker shadows and outline on the scribe bar are weird though, they don't show up on my end either. Speaking of the outline though, I can see that it exists on the original, but it's almost the same colour as the background, which means it creates a tiny gap between the bar and the shadow. This seems unintended to me, maybe we can look into this at some point as well?
All sounds good, @Jag-Marcel :) @fabulouiOS-monk, what are the specs of your simulator so we can make an issue for that? And did you switch between dark mode and light mode, perhaps? If memory serves, sometimes there's a lag where one of the styles for dark mode is still applied even after the simulator is switched :)
Hi @andrewtavis, the simulator was iPhone 15 pro (17.2) and it was in light mode(as far as I remember, I didn't switch it between dark and light mode).
Thanks so much for the further information, @fabulouiOS-monk! @Jag-Marcel, I was going to say that we can remove the border around the command bar as the shadow will cover it for us, but then in dark mode it's necessary to distinguish it from the rest of the interface. Maybe we can remove it on light mode :) I'll make an issue regardless and ping the both of you in there!
Thanks for the conversation, you two! 🚀
Minor note from the dev sync: the thought on this is that maybe the a11y settings were turned on such that the command bar was made a bit more visible? Maybe because they had a border, this border was enhanced? Thoughts on this @fabulouiOS-monk? Changes for removing it are good anyway!
Minor note from the dev sync: the thought on this is that maybe the a11y settings were turned on such that the command bar was made a bit more visible? Maybe because they had a border, this border was enhanced? Thoughts on this @fabulouiOS-monk? Changes for removing it are good anyway!
Sorry didn't get you, what is a11y settings?
Edit: Ohh got it!
Yes, a11y may be the factor for enhanced shadow and border. But if it was there for the border it should be applied to the full view and shadow.
And in future, if we are going to implement accessibility Identifiers, it can be addressed in that. Or I am fine with reverting the changes.
Thanks for checking in, @fabulouiOS-monk :) We're good with the changes. I'll send along another minor change for the command bar based on discussions we had in the dev sync. Would be great to have you in the next one! Details for that are in the general channel on Matrix.