Scribe-Data icon indicating copy to clipboard operation
Scribe-Data copied to clipboard

Incorrect Results for Non-existent Language/Data Type in total Command

Open catreedle opened this issue 1 year ago • 4 comments

Terms

Behavior

When a non-existent language or data type is provided to the total command, the system returns an incorrect number of lexemes instead of a "Not found" message.

Steps to Reproduce:

  1. Run the total command with an invalid language or data type.
  2. Observe that the command returns a number instead of indicating that the language or data type doesn't exist.

bug

Expected Behavior: When a non-existent language or data type is provided, the command should return a clear message indicating "Total number of lexemes: Not found" instead of returning incorrect results.

Proposed Solution:

  • [ ] Add a check function to validate if the provided language and data type exist in the language_metadata or data_type_metadata.
  • [ ] If either the language or data type does not exist, the system should return a "Not found" message without executing the query.

This issue is closely related to #295 This issue is blocked by #295

Contribution I would love to work and collaborate on this.

catreedle avatar Oct 10 '24 12:10 catreedle

Hi @andrewtavis, can you please add the blocked label and assign this to me? Thank you. :)

catreedle avatar Oct 10 '24 12:10 catreedle

hey @catreedle! could we collaborate on this issue? we could discuss it on Matrix. what do you think?

DeleMike avatar Oct 10 '24 13:10 DeleMike

Hi @DeleMike. Sure thing, I’d be happy to collaborate on this. Just a heads up that it's currently blocked by another issue, but we can still discuss it. :)

catreedle avatar Oct 10 '24 14:10 catreedle

cool! I'll DM you on Matrix :)

DeleMike avatar Oct 10 '24 14:10 DeleMike

Closed via #337, with the follow up work in #341 :) Thanks @catreedle!

andrewtavis avatar Oct 13 '24 21:10 andrewtavis