Scribe-Android
Scribe-Android copied to clipboard
Allow for capitalized inputs for commnds to return valid outputs
Terms
- [x] I have searched open and closed feature requests
- [x] I agree to follow Scribe-Android's Code of Conduct
Description
Something that should be finalized before the first release is that we currently are not allowing the user to pass capitalized values to all commands. An example of this is:
- In the German keyboard the user selects the Scribe key at the top left and then translate
- They type the word "Book" (note that "book" is in the database)
- The result is that they're told the word isn't in Wikidata
- Ideally we'd use the same method from Scribe-iOS
- The capitalization of the input word is derived before the database is checked and saved in a variable
- The input word is converted to lower case (except for German nouns)
- This word is checked against the database
- If the original word was capitalized, then the capitalization of the return value is returned
- If the original word wasn't capitalized, then the normal return value is returned
Contribution
Happy to support the planing for implementation here and review a PR once one is opened! 😊
Hey @andrewtavis I’d like to work on this issue, could you please assign it to me? Just to confirm, should the behavior match the iOS implementation, including handling cases like German nouns?
Yes, exactly that, @anileshwar12! Thanks for the care that you've already put into thinking about this :) Please let us know if you have further questions!
Hey @andrewtavis , If there hasn’t been any recent progress on this issue, I’d be happy to work on it. Please let me know if it’s still open for contribution. 😊
@anileshwar12, could you let us know if you still plan on working on the issue? :)
Thanks for your interest in picking this up, @Akshaykomar890! Let's give @anileshwar12 a few days to react and we'll go from there 😊
Hey @andrewtavis ,
Just checking in on this issue. If @anileshwar12 is unable to continue, I'm still interested and ready to start working on it whenever you're ready to reassign.
Thanks!
I think we're good to assign you here, @Akshaykomar890 :) Thanks so much for your patience! Please let us know if you need any support 😊
Quick check in @Akshaykomar890, do you need any assistance in working on this issue? Please let us know if you need any support!
Hey @Akshaykomar890 @anileshwar12
Hope you all are doing well. Are you still working on this issues. If not you could be unassigned. Please do share if you are facing any specific issues in solving anything particular.