Task/standardize command bar directions

[janiceferns02]

Contributor checklist

• [x] This pull request is on a separate branch and not the main branch
• [x] I have tested my code with the ./gradlew lintKotlin detekt test command as directed in the testing section of the contributing guide

---

Description

• Added : after the SOURCE_ISO -> TARGET_ISO part of the translate placeholder

• To Fix the horizontal distance between the command bar cursor character and the rest of the text

1. Removed command bar cursor character implementation using Button
2. Replaced with EditText having custom cursor drawable
3. Updated XML to use EditText inside command bar layout in both portrait and landscape xml files

Testing

1. Verified Placeholder should show in format: SOURCE_ISO -> TARGET_ISO:
2. Verified Cursor should always be visible and should move properly after each typed character
3. Verified UI Alignment in both portrait and landscape modes
4. Verified the changes in light and dark modes

Related issue

• #315

[github-actions[bot]]

Thank you for the pull request! ❤️

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

[github-actions[bot]]

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

• [x] The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

• [x] The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

[andrewtavis]

Thanks for this, @janiceferns02! We'll try to get to the review in the coming days :)

[andrewtavis]

All's looking good here, @janiceferns02! Really appreciate your initiative here 😊

Two minor comments based on the image below:

• You you remove the grey vertical bar from the prompts so that we only have the blue one?
• Could you remove the blinking for the blue cursor? This was something that we decided with the original designer a while ago, that it doesn't make sense to have the cursor blink as the normal cursor is also still blinking. As far as UI appeal, having the cursor blink out of sync with the normal one for the text proxy is also something that we can't control, so the decision was to just keep it solid.

Please let us know if you have any questions on the comments above!

[janiceferns02]

All's looking good here, @janiceferns02! Really appreciate your initiative here 😊

Two minor comments based on the image below:

• You you remove the grey vertical bar from the prompts so that we only have the blue one?
• Could you remove the blinking for the blue cursor? This was something that we decided with the original designer a while ago, that it doesn't make sense to have the cursor blink as the normal cursor is also still blinking. As far as UI appeal, having the cursor blink out of sync with the normal one for the text proxy is also something that we can't control, so the decision was to just keep it solid.

Please let us know if you have any questions on the comments above!

Understood, I will make the changes.

[andrewtavis]

Thanks much, @janiceferns02! Let us know when it's ready for another review 😊

[andrewtavis]

Quick check in here, @janiceferns02 👋 Do you need any support with the changes for this PR :) We're happy to help as needed! 😊

[DeleMike]

Hi @andrewtavis

I will look into this.

---

I understand that this will affect the way the command bar appears. To help us, I want to know the current state of the command bar and what is the goal/expectation ?

[andrewtavis]

Thanks for your interest to help here, @DeleMike! Firstly, @janiceferns02, if you want to continue with this PR, please do let us know :) We'd be happy to support if you'd like to continue the work for #315! If not, then I'm sure that @angrezichatterbox can finalize the merge conflict and @DeleMike can finalize the work in a new PR 😊

@DeleMike, the main issue here is that we have some issues with the styling of the command bar cursor. We'd like the general shape to be something like the following:

Conjugate: │

The │ character would then move as the user types to act as a normal cursor. As of now there's a blink to the cursor that needs to be removed and a few other changes are needed. Depending on availability, maybe @angrezichatterbox can fix the merge conflict in the coming days, and then from there I'll detail all the remaining changes in the issue and would assign you at that point :)

[DeleMike]

Alright, thanks! I will wait for the update.

[angrezichatterbox]

There are some more minor changes I have to make and it would be ready for the merge.

[angrezichatterbox]

It is ready for the final review :)

[angrezichatterbox]

I had to make some minute changes and remove some abstraction done to the codebase which seemed to be no longer easily usable.