Scribe-Android icon indicating copy to clipboard operation
Scribe-Android copied to clipboard

add dividers between autosuggestion #122

Open catreedle opened this issue 1 year ago • 2 comments

Contributor checklist


Description

This PR adds dividers between the autosuggestion buttons. divide Since the separator already exists, I made minor adjustments to the keyboard_view_command_options.xml file.

Please let me know if this approach is incorrect or if there are other considerations I should keep in mind. I look forward to your feedback! :)

Thank you!

Related issue

  • #122

catreedle avatar Oct 09 '24 01:10 catreedle

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • [x] The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Android repo
  • [x] The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • [x] The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

github-actions[bot] avatar Oct 09 '24 01:10 github-actions[bot]

This is generally looking great, @catreedle, but one thing would be that on dark mode they should be a bit more grey :) We can do the color of the dark mode special keys for now. I think this will be good to merge after that!

andrewtavis avatar Oct 09 '24 10:10 andrewtavis

You're right! I didn’t notice the color was off. I thought dark mode already looked different, but it turns out it’s just the contrast 😅. I’ll do my best to fix it

catreedle avatar Oct 10 '24 00:10 catreedle