terraform-aws-datadog icon indicating copy to clipboard operation
terraform-aws-datadog copied to clipboard

Enable supplying arbitrary tags

Open jim80net opened this issue 5 years ago • 3 comments

I want to supply a tags parameter with an arbitrary map of tags, potentially eliminating the hard coded Namespace and Env parameters. So that I don't have to be limited by only env and namespace.

Given we've already an expectation to support these parameters, perhaps in implementation we can simply add tags, and deprecate the namespace and env parameters until users have converged on the new mechanism.

jim80net avatar Feb 25 '20 19:02 jim80net

I like the idea of supporting arbitrary map of tags as well. Only question I have is if we remove special tags like namespace and env, how should we generate unique name for resources. Adding all the tags to the name can easily cause errors like exceeding max length constraint.

Perhaps a middle ground is to support arbitrary map of tags but keep namespace and env as special tags that will be used for constructing unique ids and names?

houqp avatar Feb 25 '20 20:02 houqp

btw, what is that namespace tag? I've never used datadog before, but can't find any namespace tag mention in their documentation, why it's special? What it's used for? To distinguish different AWS accounts and their metrics?

and uniq names could be generated using random provider in tf.

Art3mK avatar Jun 30 '20 07:06 Art3mK

@Art3mK this is for human readable prefixes, we also use it to tag resources for each individual teams since each team has its own AWS account.

houqp avatar Jul 02 '20 04:07 houqp