screwdriver icon indicating copy to clipboard operation
screwdriver copied to clipboard

UI - Workflow graph should place nodes at maximum possible depth

Open jithine opened this issue 4 years ago • 2 comments

What happened:

Nodes in workflow graph are placed at minimum possible depth which can cause graph rendering constricted.

What you expected to happen: Each node in workflow graph should be placed in maximum possible depth

How to reproduce it:

screwdriver.yaml

shared:
    image: node:12
jobs:
    A:
        requires: [~pr, B]
        steps:
            - runA
    B:       
        requires: [~pr, ~commit]
        steps:
            - runB
Screen Shot 2021-01-27 at 10 23 02 AM

Node B should be placed in the workflow graph in 3rd column rather than 2nd column like how it's rendered today.

jithine avatar Jan 27 '21 18:01 jithine

cc @adong @OronNadiv

jithine avatar Jan 27 '21 18:01 jithine

If we set template to job A, then the workflow graph on validator page will be the following. But this behavior does not occur on pipeline pages.

shared:
    image: node:12
jobs:
    A:
        requires: [~pr, B]
        template: nodejs/test@latest
        steps:
            - runA
    B:
        requires: [~pr, ~commit]
        steps:
            - runB

validator-template

y-oksaku avatar Apr 01 '22 05:04 y-oksaku