w3lib
w3lib copied to clipboard
fix(url): canonicalize_url('http://您好.中国:80/') failed
expect: 'http://xn--5usr0o.xn--fiqs8s:80/'
actual: 'http://xn--5usr0o.xn--:80-u68dy61b/'
Codecov Report
Merging #98 into master will increase coverage by
0.73%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #98 +/- ##
==========================================
+ Coverage 94.88% 95.61% +0.73%
==========================================
Files 7 7
Lines 469 593 +124
Branches 95 132 +37
==========================================
+ Hits 445 567 +122
- Misses 16 17 +1
- Partials 8 9 +1
Impacted Files | Coverage Δ | |
---|---|---|
w3lib/url.py | 97.21% <100%> (+0.32%) |
:arrow_up: |
w3lib/encoding.py | 100% <0%> (ø) |
:arrow_up: |
ERROR: pypy: InterpreterNotFound: pypy
A good catch @pp-qq !
This also affects safe_url_string()
(and would be fixed too with your change to _safe_ParseResult()
)
This change needs an update to the tests. Could you add 1 or 2 for this case?
@pp-qq , the issue with pypy on Travis is unrelated. I'm trying to fix it in #99
ERROR: pypy: InterpreterNotFound: pypy ERROR: The command "pip install -U tox twine wheel codecov" failed and exited with 2 during .
Bumping to close outdated PR.