scrapyd
scrapyd copied to clipboard
Listen on unix socket
This allows securing the app from users on the same system, provided that the effective group id of scrapyd's process is properly chosen.
Perhaps the app should also stop using tcp by default.
Codecov Report
Merging #325 into master will decrease coverage by
0.54%
. The diff coverage is61.53%
.
@@ Coverage Diff @@
## master #325 +/- ##
==========================================
- Coverage 68.77% 68.23% -0.55%
==========================================
Files 16 16
Lines 823 831 +8
Branches 96 89 -7
==========================================
+ Hits 566 567 +1
- Misses 229 234 +5
- Partials 28 30 +2
Impacted Files | Coverage Δ | |
---|---|---|
scrapyd/app.py | 88.63% <61.53%> (-11.37%) |
:arrow_down: |
scrapyd/webservice.py | 28.2% <0%> (-1.71%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 21135a0...f917e75. Read the comment docs.
Codecov Report
Merging #325 into master will decrease coverage by
0.3%
. The diff coverage is61.53%
.
@@ Coverage Diff @@
## master #325 +/- ##
==========================================
- Coverage 68.77% 68.47% -0.31%
==========================================
Files 16 16
Lines 823 831 +8
Branches 96 98 +2
==========================================
+ Hits 566 569 +3
- Misses 229 232 +3
- Partials 28 30 +2
Impacted Files | Coverage Δ | |
---|---|---|
scrapyd/app.py | 88.63% <61.53%> (-11.37%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 21135a0...f917e75. Read the comment docs.
integrated with current master here https://github.com/scrapy/scrapyd/compare/uds?expand=1
The problem (authentication) seems to be equally solved by HTTP basic authentication, which is already merged. (The Unix socket strategy is to use filesystem permissions to prevent other users from connecting to the socket.)
Since this is not related to any feature request issue (i.e. no clear demand), I'll close.