scrapyd icon indicating copy to clipboard operation
scrapyd copied to clipboard

Build eggs in test env

Open Digenis opened this issue 9 years ago • 5 comments

There are 2 binary eggs in master, containing pyc files. Besides making reviewing harder (need to decompile) I'd expect them to bug us when testing in different pythons (the old egg is for py2.6).

Maybe tests should build the eggs. This can prevent/complicate testing with eggs from different pythons so we should decide whether such compatibility is a target.

Digenis avatar Feb 11 '16 15:02 Digenis

The eggs are for scrapy<1.0 and don't work with scrapy-1.6.

Digenis avatar Jun 13 '19 05:06 Digenis

@Digenis Did you say eggs in https://github.com/scrapy/scrapyd/tree/master/scrapyd/tests ? I found both py and pyc files in eggs. And what about testing different eggs according to the Python version.

my8100 avatar Jun 13 '19 05:06 my8100

egg compatibility across different pythons is not our problem to solve. pkg_resources handles this.

This ticket is about replacing the binary eggs in the tests/ folder with scrapy projects that will be built to eggs during testing, in the test env.

Digenis avatar Jun 13 '19 06:06 Digenis

Hello! I am interested in this issue! Is it still open?

atranou avatar Apr 04 '22 12:04 atranou

@atranou It is open. Thanks for your interest!

jpmckinney avatar Apr 04 '22 15:04 jpmckinney