itemadapter

itemadapter copied to clipboard

Closes #78

Laerte

As we support PyPy in Scrapy we need to run tests on PyPy and have PyPy in classifiers.

wRAR

Update pydantic dependency to >= 2

2

I have used bump-pydantic on the code base to do the initial migration. Afterwards I had to work on some details (e.g. `__fields__` -> `model_fields`). Please note, that I am...

dvzrv

Pydantic 2 released

2

Since release of Pydantic 2, the implementation is broken due to massive restructs.

sla-te

e.g. ```python def asdict(*, unset_values=None) -> dict: if unset_values is None: unset_values = set() return _asdict(self, unset_values) ... def _asdict(obj: Any, unset_values) -> Any: if isinstance(obj, dict): return {key: _asdict(value,...

Gallaecio

is_item can be costly

4

See https://github.com/scrapy/itemloaders/issues/50 While that issue can be addressed in a different way, I am thinking that we should make some work to minimize the CPU cost of this function. I...

Gallaecio

Gallaecio

Also run tests without extra dependencies

1

Continuation of #22 which also prevents extra packages from being imported during test execution even if they are installed. Fixes #10, closes #22

Gallaecio

Tox env with no dependencies

8

Fixes #10 Two problems with this: * ~[Merging reports](https://docs.codecov.io/docs/merging-reports) does not seem to be working, coverage report shows a 13.9% decrease that is not actually accurate.~ * `attrs` is a...

elacuesta

provide a test environment with missing dependencies

2

This should allow to drop some of the mock usages, and test it for real that the package works. I think a single environment without all the dependencies could work;...

kmike