cssselect icon indicating copy to clipboard operation
cssselect copied to clipboard

Remove unused FunctionalPseudoElement methods

Open Gallaecio opened this issue 4 years ago • 3 comments

Gallaecio avatar Oct 22 '19 16:10 Gallaecio

parsel has xpath_attr_functional_pseudo_element which calls function.argument_types(). I haven't tested if this removal affects it See https://github.com/scrapy/parsel/blob/bcfa589e5f15b8f4230a699a0d64a3205732a317/parsel/csstranslator.py#L85

redapple avatar Oct 22 '19 16:10 redapple

Codecov Report

Merging #100 (9ba91e9) into master (48bbfb1) will increase coverage by 0.11%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
+ Coverage   96.04%   96.15%   +0.11%     
==========================================
  Files           2        2              
  Lines         884      884              
  Branches      176      176              
==========================================
+ Hits          849      850       +1     
+ Misses         19       18       -1     
  Partials       16       16              
Impacted Files Coverage Δ
cssselect/parser.py 97.07% <0.00%> (+0.18%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Oct 22 '19 16:10 codecov[bot]

Thanks, I had no idea of the implications. Switched my approach from removing the code to adding tests for it.

Gallaecio avatar Oct 22 '19 17:10 Gallaecio