scrapy-splash icon indicating copy to clipboard operation
scrapy-splash copied to clipboard

add SplashHtmlResponse (extended #115)

Open iAnanich opened this issue 6 years ago • 7 comments

Contains rebased @atultherejput commits from #115 with more test cases and little improvements.

iAnanich avatar Jan 19 '18 03:01 iAnanich

Codecov Report

Merging #160 into master will increase coverage by 0.09%. The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
+ Coverage   92.66%   92.76%   +0.09%     
==========================================
  Files           9        9              
  Lines         586      594       +8     
  Branches      118      120       +2     
==========================================
+ Hits          543      551       +8     
  Misses         21       21              
  Partials       22       22
Impacted Files Coverage Δ
scrapy_splash/responsetypes.py 100% <ø> (ø) :arrow_up:
scrapy_splash/__init__.py 100% <100%> (ø) :arrow_up:
scrapy_splash/response.py 94.23% <100%> (+0.17%) :arrow_up:
scrapy_splash/middleware.py 89.88% <88.88%> (+0.19%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6fb8c41...6340dad. Read the comment docs.

codecov[bot] avatar Jan 19 '18 15:01 codecov[bot]

For reference: Fixes #114

Gallaecio avatar Apr 05 '19 04:04 Gallaecio

@iAnanich It’s been a while, any chance you will resume this work, or should we close?

Gallaecio avatar Aug 05 '19 14:08 Gallaecio

Codecov Report

Merging #160 into master will increase coverage by 0.12%. The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
+ Coverage   92.63%   92.76%   +0.12%     
==========================================
  Files           9        9              
  Lines         584      594      +10     
  Branches      117      120       +3     
==========================================
+ Hits          541      551      +10     
  Misses         21       21              
  Partials       22       22
Impacted Files Coverage Δ
scrapy_splash/responsetypes.py 100% <ø> (ø) :arrow_up:
scrapy_splash/__init__.py 100% <100%> (ø) :arrow_up:
scrapy_splash/response.py 94.23% <100%> (+0.17%) :arrow_up:
scrapy_splash/middleware.py 89.88% <88.88%> (+0.19%) :arrow_up:
scrapy_splash/utils.py 97.01% <0%> (+0.09%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2aaa79d...6340dad. Read the comment docs.

codecov-io avatar Feb 23 '20 22:02 codecov-io

@Gallaecio yeah, a long time. So what needs to be done? I don't remember how, but I got around the problem.

iAnanich avatar Feb 24 '20 10:02 iAnanich

So what needs to be done?

Please, have a look at my feedback above when you have time, see if you can address it.

Gallaecio avatar Feb 25 '20 23:02 Gallaecio

Is this being worked on?

lucaguarro avatar Apr 06 '22 19:04 lucaguarro