scrapy-splash
scrapy-splash copied to clipboard
add SplashHtmlResponse (extended #115)
Contains rebased @atultherejput commits from #115 with more test cases and little improvements.
Codecov Report
Merging #160 into master will increase coverage by
0.09%
. The diff coverage is92.85%
.
@@ Coverage Diff @@
## master #160 +/- ##
==========================================
+ Coverage 92.66% 92.76% +0.09%
==========================================
Files 9 9
Lines 586 594 +8
Branches 118 120 +2
==========================================
+ Hits 543 551 +8
Misses 21 21
Partials 22 22
Impacted Files | Coverage Δ | |
---|---|---|
scrapy_splash/responsetypes.py | 100% <ø> (ø) |
:arrow_up: |
scrapy_splash/__init__.py | 100% <100%> (ø) |
:arrow_up: |
scrapy_splash/response.py | 94.23% <100%> (+0.17%) |
:arrow_up: |
scrapy_splash/middleware.py | 89.88% <88.88%> (+0.19%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6fb8c41...6340dad. Read the comment docs.
For reference: Fixes #114
@iAnanich It’s been a while, any chance you will resume this work, or should we close?
Codecov Report
Merging #160 into master will increase coverage by
0.12%
. The diff coverage is92.85%
.
@@ Coverage Diff @@
## master #160 +/- ##
==========================================
+ Coverage 92.63% 92.76% +0.12%
==========================================
Files 9 9
Lines 584 594 +10
Branches 117 120 +3
==========================================
+ Hits 541 551 +10
Misses 21 21
Partials 22 22
Impacted Files | Coverage Δ | |
---|---|---|
scrapy_splash/responsetypes.py | 100% <ø> (ø) |
:arrow_up: |
scrapy_splash/__init__.py | 100% <100%> (ø) |
:arrow_up: |
scrapy_splash/response.py | 94.23% <100%> (+0.17%) |
:arrow_up: |
scrapy_splash/middleware.py | 89.88% <88.88%> (+0.19%) |
:arrow_up: |
scrapy_splash/utils.py | 97.01% <0%> (+0.09%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2aaa79d...6340dad. Read the comment docs.
@Gallaecio yeah, a long time. So what needs to be done? I don't remember how, but I got around the problem.
So what needs to be done?
Please, have a look at my feedback above when you have time, see if you can address it.
Is this being worked on?