scrapy-splash icon indicating copy to clipboard operation
scrapy-splash copied to clipboard

Published 20 hours ago • verified publisher icon scrapy-plugins

Allow spider attr

Open pawelmhm opened this issue 9 years ago • 5 comments

This is about https://github.com/scrapinghub/scrapyjs/issues/14 and https://github.com/scrapinghub/scrapyjs/issues/11

opening this for discussion, needs tests and improvements, would be cool to get some feedback if it's in good direction

pawelmhm avatar Apr 10 '15 11:04 pawelmhm

updated after discussions

pawelmhm avatar May 26 '15 07:05 pawelmhm

@pawelmhm tests are failing

chekunkov avatar Jun 09 '15 09:06 chekunkov

TODO

  • [ ] docs

something else?

pawelmhm avatar Jun 19 '15 12:06 pawelmhm

I know it has been a rather long time, but it looks like this is still a valid pull request, and a nice once at that. It seems to me like it’s only missing renaming dont_proxy to something else and covering the changes in the documentation.

@pawelmhm Do you have plans to resume work on it at some point?

Gallaecio avatar Jul 11 '19 11:07 Gallaecio

Continued at #235

Gallaecio avatar Aug 12 '19 15:08 Gallaecio