scrapy-playwright icon indicating copy to clipboard operation
scrapy-playwright copied to clipboard

Wrapper to assign futures to the correct event loop

Open elacuesta opened this issue 1 year ago • 1 comments

Closes #307

Tasks:

  • [x] implementation (I'm working on a callback decorator instead)
  • [ ] tests
  • [ ] docs

elacuesta avatar Jul 23 '24 19:07 elacuesta

Codecov Report

:x: Patch coverage is 60.60606% with 13 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 93.21%. Comparing base (84ba393) to head (147db94). :warning: Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
scrapy_playwright/utils.py 60.86% 9 Missing :warning:
scrapy_playwright/_utils.py 62.50% 3 Missing :warning:
scrapy_playwright/handler.py 50.00% 1 Missing :warning:

:exclamation: There is a different number of reports uploaded between BASE (84ba393) and HEAD (147db94). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (84ba393) HEAD (147db94)
6 3
Additional details and impacted files
@@             Coverage Diff             @@
##              main     #308      +/-   ##
===========================================
- Coverage   100.00%   93.21%   -6.79%     
===========================================
  Files            6        7       +1     
  Lines          603      634      +31     
===========================================
- Hits           603      591      -12     
- Misses           0       43      +43     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jul 23 '24 20:07 codecov[bot]

Fixed by #351, closing.

elacuesta avatar Aug 13 '25 19:08 elacuesta