scrapy-playwright icon indicating copy to clipboard operation
scrapy-playwright copied to clipboard

Supporting for windows

Open sanzenwin opened this issue 1 year ago • 4 comments

sanzenwin avatar Nov 30 '23 11:11 sanzenwin

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (5b254e4) 100.00% compared to head (cc4c4ac) 95.77%. Report is 2 commits behind head on main.

:exclamation: Current head cc4c4ac differs from pull request most recent head a6b9f6e. Consider uploading reports for the commit a6b9f6e to get more accurate results

Files Patch % Lines
scrapy_playwright/handler.py 31.03% 20 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##              main     #251      +/-   ##
===========================================
- Coverage   100.00%   95.77%   -4.23%     
===========================================
  Files            5        5              
  Lines          448      473      +25     
===========================================
+ Hits           448      453       +5     
- Misses           0       20      +20     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 30 '23 12:11 codecov[bot]

Is this pull request still actively being worked on? @sanzenwin @elacuesta

ProfoundWanderer avatar Mar 11 '24 20:03 ProfoundWanderer

I personally am not working on this at the moment. I left a few comments/suggestions/questions in this PR. I will try to find some time to work on this in the near future, but I can't make any promises. The best way of using this package on Windows is still under WSL.

elacuesta avatar Mar 11 '24 21:03 elacuesta

I personally am not working on this at the moment. I left a few comments/suggestions/questions in this PR. I will try to find some time to work on this in the near future, but I can't make any promises.

The best way of using this package on Windows is still under WSL.

I don't mind trying to work on it, I just didn't want to step on any toes. Personally, didn't want to go through WSL hoops if it was possible to get this supported on Windows at all.

ProfoundWanderer avatar Mar 11 '24 21:03 ProfoundWanderer