quill-resize-module icon indicating copy to clipboard operation
quill-resize-module copied to clipboard

How to lock the resize ratio?

Open artknight opened this issue 3 years ago • 6 comments

Hi, I am not able to find how to lock the resize ratio, meaning that when I am resizing I would like the image not to get distorted :)

artknight avatar Sep 06 '22 16:09 artknight

@artknight 。press and hold alt

scrapooo avatar Sep 07 '22 01:09 scrapooo

@scrapooo I have added an option to keep the ratio by setting the ratioLock: true option. Also updated the toolbar to be nicer :) Here is the PR https://github.com/scrapooo/quill-resize-module/pull/8

artknight avatar Sep 07 '22 16:09 artknight

@artknight Thank you for providing the modification, but I think lockRatio is a good idea. Can you help me add this lockRatio option. I need to consider whether other ideas are appropriate.

scrapooo avatar Sep 08 '22 08:09 scrapooo

My PR https://github.com/scrapooo/quill-resize-module/pull/8 did just that, but you closed it? Why?

artknight avatar Sep 08 '22 12:09 artknight

@artknight Sorry, I didn't explain why. This pull request wants to be merged into the master, and I expect to be merged into the develop. Another reason is that there are too many modifications and the submission message does not follow the submission specification. https://github.com/angular/angular/blob/main/CONTRIBUTING.md#-commit-message-format

scrapooo avatar Sep 09 '22 02:09 scrapooo

@artknight The toolbar style you provided is very nice, and I decided to adopt it. Thanks.

scrapooo avatar Sep 09 '22 02:09 scrapooo

Hello, the ratioLock: true are not working, the PR was declined, then never was fixed the specification?

vagkaefer avatar Jun 08 '25 15:06 vagkaefer