spidermon icon indicating copy to clipboard operation
spidermon copied to clipboard

fix: (423-fix_time_zone) - making timezone aware if needed

Open further-reading opened this issue 2 years ago • 4 comments

Closes #423 Error handling adds timezone if needed.

further-reading avatar Oct 15 '23 14:10 further-reading

Tests fail because they expect self.crawler.stats which is None, I assume it's because of the Scrapy 2.11 change to the crawler initialization. One way to work around this in tests is to assign MemoryStatsCollector(crawler) to it manually if it's None (if tests don't expect any other components of the Crawler instance to be initialized), like in https://github.com/scrapinghub/scrapy-poet/pull/165

wRAR avatar Oct 16 '23 07:10 wRAR

The CI issues have been fixed 🙏 Could you rebase/merge the latest changes from master? @further-reading

curita avatar Nov 27 '23 18:11 curita

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.42%. Comparing base (ab611d6) to head (908e4ae).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #424      +/-   ##
==========================================
+ Coverage   79.39%   79.42%   +0.02%     
==========================================
  Files          76       76              
  Lines        3223     3227       +4     
  Branches      534      534              
==========================================
+ Hits         2559     2563       +4     
  Misses        593      593              
  Partials       71       71              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 29 '23 09:11 codecov[bot]

The CI issues have been fixed 🙏 Could you rebase/merge the latest changes from master? @further-reading

@curita Done now, but we have a codecov error as it wants me to add unit tests. I won't have the bandwidth to add these soon I'm afraid.

further-reading avatar Nov 29 '23 11:11 further-reading

I'm not sure but I think the test isn't related to the code being tested? I assume it increased the coverage for some of the added lines but not because it tests the added code.

wRAR avatar Mar 08 '24 08:03 wRAR

Fixed at https://github.com/scrapinghub/spidermon/pull/439

VMRuiz avatar Apr 17 '24 10:04 VMRuiz