spidermon icon indicating copy to clipboard operation
spidermon copied to clipboard

Create tests for PythonExpressionsMonitor

Open rennerocha opened this issue 6 years ago • 4 comments

This feature is not tested: https://github.com/scrapinghub/spidermon/blob/master/spidermon/python/factory.py#L12

rennerocha avatar Feb 19 '19 02:02 rennerocha

#89 happened because the lack of tests of this class.

rennerocha avatar Feb 19 '19 02:02 rennerocha

@rennerocha I started to work on this issue and I have a simple question. As a factory of python expression monitors, the tests for this feature should be under the test_monitors class, or it would be good to have it in a different class for clarity (as test_monitors tests refer to built-in scrapy monitors).

Also, could you give me a simple example of expression we are expected to receive to be monitored?

leovictorsr avatar Apr 02 '19 23:04 leovictorsr

https://github.com/scrapinghub/spidermon/blob/master/tests/contrib/scrapy/test_extensions.py

rosheen33 avatar Jun 20 '19 10:06 rosheen33

Is this still relevant&available? I'd like to work this if possible

mirceachira avatar Dec 21 '19 13:12 mirceachira