page_clustering
page_clustering copied to clipboard
Py3
Tests pass, looks like the only real issue was map
being a generator in Py2.
Cool! Can you update the travis config to run Py3 tests? Example matrix config: https://github.com/scrapy/scrapy/blob/master/.travis.yml#L8
I modified the tox.ini
file, will that suffice? :)
Derp, I clearly don't grok travis yet.
@redapple No. It's not ideal, though, because it means you can't run multiple version checks with one invocation of tox
. The way I had it at first, running tox
would check both versions at once. But that didn't play well with Travis.
To test locally now, you'd do python{x} -m tox
to test Python x.
In other projects, we've been using TOXENV
in the matrix in Travis and it's been working well.
And local tests still use tox -e py27,py35
for example.
See https://github.com/scrapinghub/extruct/blob/master/.travis.yml for example