number-parser
number-parser copied to clipboard
Fixed Issue#66
Regarding isssues#66, added encoding='utf8'
to the open()
function on line 23 in __init__.py
. This fixes the pytest issues for Hindi, Spanish and Russian on Windows.
Codecov Report
Merging #67 (4effdd8) into master (c834854) will not change coverage. The diff coverage is
n/a
.
:exclamation: Current head 4effdd8 differs from pull request most recent head 3ee2ed4. Consider uploading reports for the commit 3ee2ed4 to get more accurate results
@@ Coverage Diff @@
## master #67 +/- ##
=======================================
Coverage 98.78% 98.78%
=======================================
Files 86 86
Lines 328 328
Branches 60 60
=======================================
Hits 324 324
Misses 1 1
Partials 3 3
Nice.
Did you check if there were any other open
calls without the encoding
parameters in the code base? (if so, we should aim to fix them all at once here).
It would also be a great opportunity to add Windows to the CI.
Hi @Gallaecio hope you and your family are safe. I looked and did not find any other open calls without encoding, also added Windows to the CI. I wanted to ask, why are there two github action configurations, one with python39 testing and one without it?
Could you remove the one without Python 3.9? I believe it is an unused, leftover file.