Addition: Docs need to say that _refresh_states() also takes a non iterable

Open IAlwaysBeCoding opened this issue 7 years ago • 1 comments

The docs need to be changed to let the user know that _refresh_states() also takes a non iterable, aka a single object not contained in a list.

https://github.com/scrapinghub/frontera/blob/8ac23162e97f6e685534c029e1da19d867c037d7/frontera/strategy/init.py#L139-L145

That's because the function refresh_and_keep() converts the non iterable object into a non-iterable object contained within a list.

https://github.com/scrapinghub/frontera/blob/8ac23162e97f6e685534c029e1da19d867c037d7/frontera/core/manager.py#L818-L822

Nov 21 '18 21:11 IAlwaysBeCoding

Good catch! Can you make PR @IAlwaysBeCoding ?

Nov 22 '18 17:11 sibiryakov