frontera
frontera copied to clipboard
Fix bug when ordering elements on queue when get next batch of requests
I found that when using a MySQL database as backend the queue
table was being consumed in the opposite order as intended (elements with lower priority were being consumed first).
I found that on the queue
component the _order_by
method had no default order condition, so I added an explicit desc()
clause (elements with bigger priority first). I guess this can apply to other backends (Postgres).
Thanks!
Great! Thanks for this fix!
@sibiryakov what do you think of this? Can we merge it? Thanks!
hey @jpbalarini thanks for the contribution, will try to respond quicker next time. It seems this wasn't covered with the test, can you add them?
@sibiryakov done! added tests for the SQL alchemy Queue
component. That class should have 100% code coverage now.
Thanks!
Hi @sibiryakov I added the tests and everything as requested some time ago. Thanks!
When this fix will be applied?