frontera icon indicating copy to clipboard operation
frontera copied to clipboard

Add support for “post requests and data” when integrating scrapy.

Open CN-hanyi opened this issue 7 years ago • 2 comments

Add support for “post requests and data” when integrating scrapy. Resolve the bug for “wrong request data in metadata” when response updates metadata.

CN-hanyi avatar Jan 30 '18 12:01 CN-hanyi

Hi @CN-hanyi thank you for your PR! Would be great to have a tests passing and to propagate your changes to all backends: Memory, HBase, MessageBus. Probably it's also worth to check if it needs to be mentioned in docs.

sibiryakov avatar Feb 02 '18 07:02 sibiryakov

Thanks for your reply. I have added the test for the submitted code. Add test for “post request and data support when integrating scrapy ” , propagate this change to all backends: memory, hbase,redis . propagate this change to json codecs。 Add MessageBusBackend test for new codecs(json and msgpack)。 Fix some bugs after the test.

CN-hanyi avatar Feb 03 '18 14:02 CN-hanyi