dateparser icon indicating copy to clipboard operation
dateparser copied to clipboard

Add "black" for code formatting?

Open kishan3 opened this issue 2 years ago • 1 comments

Hello Guys,

Should dateparser library be using black for code formatting ?

https://black.readthedocs.io/en/stable/ There is also blue: https://blue.readthedocs.io/en/latest/

kishan3 avatar Sep 14 '21 06:09 kishan3

Using some code formatters like black or blue help to have a more standarized code, but at the same time can be annoying.

I'm not 100% sure of adding this, but in case we do it, before applying black, we should need a mechanism (pipelines) to ensure that:

  • Some selected files use black/blue (and we add more files slowly) or
  • New code uses black/blue formatting or
  • Black/Blue is automatically applied in PRs

Only after adding one of these mechanism we can start changing the files. Any preference on it?

Also, could you expose advantages/disadvantages of using them, and differences among different alternatives (black, blue, etc)?

Thanks!

noviluni avatar Oct 05 '21 07:10 noviluni

I closed this issue because PR is merged.

serhii73 avatar Apr 19 '23 14:04 serhii73